From 438a49466c72a03340df267a9c654309e72409c0 Mon Sep 17 00:00:00 2001 From: maskers <97827489+maskersss@users.noreply.github.com> Date: Mon, 5 Aug 2024 01:52:06 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: seth Signed-off-by: maskers <97827489+maskersss@users.noreply.github.com> --- src/handlers/event/analyze_logs/issues.rs | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/handlers/event/analyze_logs/issues.rs b/src/handlers/event/analyze_logs/issues.rs index c9191b0..0e04fe3 100644 --- a/src/handlers/event/analyze_logs/issues.rs +++ b/src/handlers/event/analyze_logs/issues.rs @@ -225,21 +225,20 @@ async fn outdated_launcher(log: &str, data: &Data) -> Result { || (log_version_parts[0] == latest_version_parts[0] && log_version_parts[1] < latest_version_parts[1]) { - if log_version_parts[0] < 8 { - let issue = ( + let issue = if log_version_parts[0] < 8 { + ( "Outdated Prism Launcher".to_string(), format!("Your installed version is {log_version}, while the newest version is {latest_version}.\nPlease update; for more info see https://prismlauncher.org/download/") - ); + ) - Ok(Some(issue)) } else { - let issue = ( + ( "Outdated Prism Launcher".to_string(), format!("Your installed version is {log_version}, while the newest version is {latest_version}.\nPlease update by pressing the `Update` button in the launcher or using your package manager.") - ); - - Ok(Some(issue)) - } + ) + }; + + Ok(Some(issue)) } else { Ok(None) }