refactor: harden clippy lints

src/handlers/event/analyze_logs/issues.rs

@@ -6,7 +6,7 @@ use regex::Regex;
 
 pub type Issue = Option<(String, String)>;
 
-pub async fn find_issues(log: &str, data: &Data) -> Result<Vec<(String, String)>> {
+pub async fn find(log: &str, data: &Data) -> Result<Vec<(String, String)>> {
 	let issues = [
 		fabric_internal,
 		flatpak_nvidia,
@@ -24,7 +24,7 @@ pub async fn find_issues(log: &str, data: &Data) -> Result<Vec<(String, String)>
 	let mut res: Vec<(String, String)> = issues.iter().filter_map(|issue| issue(log)).collect();
 
 	if let Some(issues) = outdated_launcher(log, data).await? {
-		res.push(issues)
+		res.push(issues);
 	}
 
 	Ok(res)

src/handlers/event/analyze_logs/mod.rs

@@ -2,7 +2,7 @@ use crate::consts::COLORS;
 use crate::Data;
 
 use color_eyre::eyre::Result;
-use log::*;
+use log::debug;
 use poise::serenity_prelude::{
 	Context, CreateAllowedMentions, CreateEmbed, CreateMessage, Message,
 };
@@ -10,7 +10,6 @@ use poise::serenity_prelude::{
 mod issues;
 mod providers;
 
-use issues::find_issues;
 use providers::find_log;
 
 pub async fn handle(ctx: &Context, message: &Message, data: &Data) -> Result<()> {
@@ -38,7 +37,7 @@ pub async fn handle(ctx: &Context, message: &Message, data: &Data) -> Result<()>
 		return Ok(());
 	};
 
-	let issues = find_issues(&log, data).await?;
+	let issues = issues::find(&log, data).await?;
 
 	let embed = {
 		let mut e = CreateEmbed::new().title("Log analysis");

src/handlers/event/mod.rs

@@ -1,7 +1,7 @@
 use crate::{api, Data};
 
 use color_eyre::eyre::{Report, Result};
-use log::*;
+use log::{debug, info};
 use poise::serenity_prelude::{ActivityData, Context, FullEvent, OnlineStatus};
 use poise::FrameworkContext;
 
@@ -23,7 +23,7 @@ pub async fn handle(
 			info!("Logged in as {}!", data_about_bot.user.name);
 
 			let latest_minecraft_version = api::prism_meta::get_latest_minecraft_version().await?;
-			let activity = ActivityData::playing(format!("Minecraft {}", latest_minecraft_version));
+			let activity = ActivityData::playing(format!("Minecraft {latest_minecraft_version}"));
 
 			info!("Setting presence to activity {activity:#?}");
 			ctx.set_presence(Some(activity), OnlineStatus::Online);

src/handlers/event/pluralkit.rs

@@ -2,7 +2,7 @@ use crate::{api, Data};
 use std::time::Duration;
 
 use color_eyre::eyre::Result;
-use log::*;
+use log::debug;
 use poise::serenity_prelude::{Context, Message};
 use tokio::time::sleep;
 

src/handlers/event/support_onboard.rs

@@ -1,5 +1,5 @@
 use color_eyre::eyre::{eyre, Result};
-use log::*;
+use log::debug;
 use poise::serenity_prelude::{
 	ChannelType, Context, CreateAllowedMentions, CreateMessage, GuildChannel,
 };
@@ -15,7 +15,7 @@ pub async fn handle(ctx: &Context, thread: &GuildChannel) -> Result<()> {
 		.ok_or_else(|| eyre!("Couldn't get parent ID from thread {}!", thread.name))?
 		.name(ctx)
 		.await
-		.unwrap_or("".to_string())
+		.unwrap_or(String::new())
 		!= "support"
 	{
 		debug!("Not posting onboarding message to threads outside of support");